Allow fakers to build on previously populated fields. #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescod
force-pushed
the
feature/contextual-fakers
branch
from
6250df2 to
58d3411
Compare
boakley
suggested changes
Aug 2, 2021
boakley
approved these changes
Aug 9, 2021
davisagli
reviewed
Aug 9, 2021
|
@davisagli : I think I'd just consider this "making fake data more realistic" and not needing of docs unless it causes some confusion or problem for someone. I'll also wait on documenting the new plugin local variables feature until someone asks for a "feature like local variables for plugins". Premature documentation locks me into a particular interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow fakers to build on previously populated fields, such as emails based on firstnames.
Currently: Emails and Usernames are based on FirstNames and LastNames.
Also adds a bit of test coverage.